Conversation
Code quality scoreLovely, the code quality is unchanged for this PR 😊
|
Member
|
There might be other areas where we use |
hapiben
approved these changes
Jun 16, 2025
paul-mesnilgrente
approved these changes
Jun 16, 2025
boost-tim
force-pushed
the
tw/upgrade-ruby
branch
from
5de9dbd to
bff2a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Dan, I want Ruby up to date on the supplejack_common, so that we are safe and secure from CVE's
Acceptance Criteria
-Rails is running on the latest Ruby (3.4.5 at the time of writing)
-The app using the latest Alpine version available for that ruby version
-NodeJS is upgraded to the version available on that Alpine version
Risks
?
Notes
-Upgrading Ruby will upgrade the Alpine version we're on and the NodeJS version too. This will help to avoid CVEs
-This might be the previous upgrade 157787